-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate any/all group include conditions. #4
Conversation
@@ -13,15 +13,9 @@ Resolves #??? | |||
|
|||
<!--- Please describe how you tested your changes. --> | |||
|
|||
## Change log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple admin files that are changed in this PR - I am fine merging as is, but felt it useful to point out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm still changing things as I see they need updates. Row will transition to a more strict one "related set of changes" per PR soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my above comment, this looks great. The syntax is very clean considering the significant complexity increase in action groups!
Description
Make
group.include
an array of tables. Elements in the array are evaluated in anany
context, allowing new use-cases. For example, one can select ranges like:to select groups where
i < 10 || i > 20
Conditions that must all be true can be set with
all
instead ofcondition
. The previous syntax:is now:
A one-liner equivalent of the previous syntax is possible, though heavy on brackets:
Motivation and context
Allow users a wider range of selection logic.
How has this been tested?
Unit tests check the given functionality.
Checklist:
doc/src/contributors.md
) in the pull request source branch.