Reanimated 4 compatible Modal overlay #3204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maltronic
force-pushed
the
patch-4
branch
3 times, most recently
from
d517c2e to
8c7e615
Compare
The existing implementation using `@legendapp/motion` is not compatible with reanimated 4 and can be replaced with in-built layout transitions: https://docs.swmansion.com/react-native-reanimated/docs/layout-animations/entering-exiting-animations
|
|
Agreed, I'd be happy to get involved if possible. This PR was really just a quick-fix to help myself and others get things over the weekend but it would be great to help get the implementation done properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation using
@legendapp/motionis not compatible with reanimated 4 and can be replaced with in-built layout transitions: https://docs.swmansion.com/react-native-reanimated/docs/layout-animations/entering-exiting-animations