Enqueue background tasks #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glujan
commented
Jan 1, 2025
| # @suppress_errors(httpx.HTTPError, PermissionError) | ||
| def _prepare_download_url( | ||
| self, product: Product, item: DownloadItem | ||
| ) -> tuple[bool, DownloadUrlResponse | None]: |
There was a problem hiding this comment.
Messy to return such a tuple. Maybe use enumeration instead of a bool to better indicate status?
glujan
force-pushed
the
Use-priority-queue
branch
from
7dd8c2a to
20341d7
Compare
glujan
force-pushed
the
Use-priority-queue
branch
8 times, most recently
from
60ab69d to
1a851b5
Compare
glujan
force-pushed
the
Use-priority-queue
branch
from
1a851b5 to
a7acaec
Compare
glujan
force-pushed
the
Use-priority-queue
branch
from
c5a9bb0 to
f4c25b5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.