Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enables Scene Builder to provide Insets editor for custom controls #594

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

Oliver-Loeffler
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler commented Oct 22, 2022

Enables editing of Insets properties in properties editor.
The MetadataIntrospector has been updated accordingly. The insets defaults are read from the introspected bean.

I'll add a test for this in a follow up commit. Ideally I'd like to move the functionality of makePropertyMetadata method into a separate class.

Issue

Fixes #532

Progress

…s editing capability demonstration to test sources.
@abhinayagarwal abhinayagarwal added this to the 22 milestone Sep 25, 2023
abhinayagarwal
abhinayagarwal previously approved these changes Mar 12, 2024
Copy link
Collaborator

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good to me.

@abhinayagarwal abhinayagarwal merged commit e1b7bb0 into gluonhq:master Mar 13, 2024
3 checks passed
@Oliver-Loeffler
Copy link
Collaborator Author

Thanks @abhinayagarwal. I'wasnt fast enough for changing the license year. Well, but within next days I'll be able to review and rework the other open items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Custom StyleableProperty In SceneBuilder
2 participants