Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use relative path for resuesable workflows in same repository #687

Merged
merged 2 commits into from
Apr 16, 2024
Merged

build: use relative path for resuesable workflows in same repository #687

merged 2 commits into from
Apr 16, 2024

Conversation

abhinayagarwal
Copy link
Collaborator

Issue

Fixes #684

Progress

@abhinayagarwal
Copy link
Collaborator Author

Hi @Oliver-Loeffler, can you review this change?

@Oliver-Loeffler
Copy link
Collaborator

Oliver-Loeffler commented Apr 15, 2024 via email

Oliver-Loeffler
Oliver-Loeffler approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really seems a quite good idea. Also the workflows seem to start properly. This looks okay to me.

@abhinayagarwal abhinayagarwal merged commit 2a81078 into gluonhq:master Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliver-Loeffler Oliver-Loeffler Oliver-Loeffler approved these changes

@aalmiray aalmiray Awaiting requested review from aalmiray

@erwin1 erwin1 Awaiting requested review from erwin1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use relative path for reusable workflows in the same repository
2 participants
@abhinayagarwal @Oliver-Loeffler