Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Checkstyle now verifies line length of Java files (<=120 char) #691

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Oliver-Loeffler
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler commented Mar 28, 2024

Added rule to check that line length in Java files not exceeds 120 chars.

Issue

Fixes #690

With the new checkstyle rule, one will now get warnings on overly long lines:

> mvn checkstyle:checkstyle
...
[WARN] PreferencesRecordDocument.java:134: Zeile ist 121 Zeichen lang (Obergrenze ist 120). [LineLength]
[WARN] PreferencesRecordDocument.java:156: Zeile ist 148 Zeichen lang (Obergrenze ist 120). [LineLength]
[WARN] PreferencesRecordGlobal.java:418: Zeile ist 125 Zeichen lang (Obergrenze ist 120). [LineLength]
[WARN] PreferencesRecordGlobal.java:423: Zeile ist 129 Zeichen lang (Obergrenze ist 120). [LineLength]
...

Progress

@Oliver-Loeffler Oliver-Loeffler merged commit 6f6ffd6 into gluonhq:master Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Coding guidelines suggest 120 chars line width but checkstyle does not verify or complain if exceeded
2 participants