Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing module to kit and update versions #729

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Sep 27, 2024

Issue

Fixes #728

Progress

@abhinayagarwal
Copy link
Collaborator

Please update the title to follow pre-defined format

@jperedadnr jperedadnr changed the title Add missing module to kit and update versions fix: Add missing module to kit and update versions Sep 28, 2024
@jperedadnr
Copy link
Collaborator Author

Done

@Oliver-Loeffler
Copy link
Collaborator

Hi @jperedadnr, while testing, I found now that one cannot longer open the preferences dialog. I was starting Scene Builder using Maven on command line with mvn javafx:run -f app. It nicely launches and one can open the provided templates and also existing FXML files. But, the preferences dialog is not showing up. I'll investigate and will see, if it can be resolved within this PR or if it requires another PR.

Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, besides the issue with the Preferences dialog. But there I'll create a new issue.

@Oliver-Loeffler Oliver-Loeffler merged commit 810650d into gluonhq:master Sep 28, 2024
3 checks passed
@Oliver-Loeffler Oliver-Loeffler added the bug Something isn't working label Sep 28, 2024
@Oliver-Loeffler Oliver-Loeffler added this to the 24 milestone Sep 28, 2024
@Oliver-Loeffler Oliver-Loeffler added the housekeeping Addresses warnings, deprecations etc. label Sep 28, 2024
@Oliver-Loeffler Oliver-Loeffler self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Addresses warnings, deprecations etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach DisplayService is needed in Kit
3 participants