Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Replaced deprecated --compress 2 option with new JLink 21 compliant --compress zip-9 #743

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

Oliver-Loeffler
Copy link
Collaborator

As with JLink 21 the option --compress 2 is deprecated, --compress zip-9 is used instead.

Issue

Fixes #741

Progress

@Oliver-Loeffler Oliver-Loeffler added housekeeping Addresses warnings, deprecations etc. packaging All related to MSI/DEB/RPM/jpackage labels Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler added this to the 24 milestone Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler self-assigned this Oct 1, 2024
@abhinayagarwal
Copy link
Collaborator

Going through the jlink command line, I found:

$ jlink --help
…
    --compress <compress>  Compression to use in compressing resources:
        Accepted values are:
        zip-[0-9], where zip-0 provides no compression,
        and zip-9 provides the best compression.
        Default is zip-6.
        Deprecated values to be removed in a future release:
        0:  No compression. Equivalent to zip-0.
        1:  Constant String Sharing
        2:  Equivalent to zip-6.
…

I am wondering if we should default to zip-6, or if zip-9 provides a better compression without any side-effects?

@Oliver-Loeffler
Copy link
Collaborator Author

Oliver-Loeffler commented Oct 2, 2024 via email

Copy link
Collaborator

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I tried both zip-6 and zip-9 on mac m1 with JDK 23.

With zip-6 the runtime created is 148.1MB (14,78,75,131 bytes) and with zip-9 it is 148MB (14,78,17,824 bytes).

@Oliver-Loeffler
Copy link
Collaborator Author

Interesting! The extacted contents of the 80 MiB MSI file is 155 MiB on Windows. I would have expected a smaller file size on Linux (at least for the package file).

@Oliver-Loeffler Oliver-Loeffler merged commit 3715983 into gluonhq:master Oct 2, 2024
3 checks passed
@Oliver-Loeffler Oliver-Loeffler deleted the issue-741 branch October 2, 2024 16:42
@abhinayagarwal
Copy link
Collaborator

The extacted contents of the 80 MiB MSI file is 155 MiB on Windows

I was talking about the runtime which is created after running the jlink command.

@Oliver-Loeffler
Copy link
Collaborator Author

Ah, yes, my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Addresses warnings, deprecations etc. packaging All related to MSI/DEB/RPM/jpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: jlink issues a deprecation warning for option --compress 2
2 participants