Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Gluon components out of Kit into new Gluon-plugin module #748

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jperedadnr
Copy link
Collaborator

Issue

Fixes #241

This PR introduces gluon-plugin as a new maven module, containing all the Gluon components (custom controls, hierarchy, metadata, themes and stylesheets), that were previously in Scene Builder Kit.

Scene Builder Kit doesn't have dependency on Gluon Charm-Glisten anymore.

Scene Builder App uses both Kit and Gluon-plugin, and therefore the end result is the same for Scene Builder users as it was before this PR.

This PR supersedes #241, which was a good start. But many things have change since it was created: we have a modular maven project, with JDK 21+, and now we can use JPMS modules and ServiceProviders to easily inject the plugin.

A few interfaces have been defined:

  • ExternalSectionProvider, to deal with the Library Section for the plugin controls
  • ExternalMetadataProvider, to deal with metadata required to manage the plugin controls
  • ExternalDesignHierarchyMaskProvider, to deal with the hierarchy tree view for the plugin controls
  • ExternalThemeProvider, to deal with the css and themes of the plugin

Developers could use the Gluon-plugin implementation for their own development of similar plugins for their libraries.

Progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant