Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsoleted readfp() with read_file(), fixes gluster/glusterfs#4403 #4404

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

hunter86bg
Copy link
Contributor

As stated in the deprecation/removal warning, readfp() is removed in python 3.12 which leads georeplication setup to fail with a traceback.

Official docs clearly state that read_file() is the proper replacement.

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@hunter86bg hunter86bg changed the title Replace obsoleted readfp() with read_file(), fixes gluster/glusterfs#4403 Replace obsoleted readfp() with read_file(), fixes glusterfs#4403 Aug 28, 2024
@hunter86bg hunter86bg changed the title Replace obsoleted readfp() with read_file(), fixes glusterfs#4403 Replace obsoleted readfp() with read_file(), fixes #4403 Aug 28, 2024
@hunter86bg hunter86bg changed the title Replace obsoleted readfp() with read_file(), fixes #4403 Replace obsoleted readfp() with read_file(), fixes gluster/glusterfs#4403 Aug 28, 2024
@hunter86bg
Copy link
Contributor Author

This one should fix #4403

@hunter86bg
Copy link
Contributor Author

As CentOS7 is dead, devrpm-el7 should not be required, right ?

@sulphur
Copy link

sulphur commented Oct 3, 2024

I've been searching for that solution for past few days. We are upgrading ubutnu to 24.04 and Gluster 11.1 and indeed Geo-replicaion is broken and i've tested by manually replacing these functions names from readfp to read_file and that seems to fix the problem. Thanks @hunter86bg for finding that. Hope it will get patched soon

@hunter86bg
Copy link
Contributor Author

@sulphur , it was reported in the mailing list by a Fedora user but I guess evry modern distro will be affected of it.

@amarts
Copy link
Member

amarts commented Oct 18, 2024

/run regression

@gluster-ant
Copy link
Collaborator

1 test(s) failed
./tests/00-geo-rep/00-georep-verify-non-root-setup.t

0 test(s) generated core

1 test(s) needed retry
./tests/00-geo-rep/00-georep-verify-non-root-setup.t
https://build.gluster.org/job/gh_centos7-regression/3416/

@amarts amarts merged commit 85ee788 into gluster:devel Oct 19, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants