afr:prevent null pointer access in afr_notify#4645
Open
YifanZhang-311 wants to merge 1 commit intogluster:develfrom
Open
afr:prevent null pointer access in afr_notify#4645YifanZhang-311 wants to merge 1 commit intogluster:develfrom
YifanZhang-311 wants to merge 1 commit intogluster:develfrom
Conversation
YifanZhang-311
force-pushed
the
fix/afr-notify-null-ptr
branch
3 times, most recently
from
3401c3a to
8f308d2
Compare
Author
|
Hi, @pranithk , could you please review this patch when you have a moment？ Thanks :) |
YifanZhang-311
force-pushed
the
fix/afr-notify-null-ptr
branch
2 times, most recently
from
a2d007f to
d874703
Compare
Protect afr_has_quorum with a lock to prevent access to this->private which could be freed by glusterfs_graph_fini in another thread. Fixex: gluster#4644
YifanZhang-311
force-pushed
the
fix/afr-notify-null-ptr
branch
from
d874703 to
ce0f7fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for the
this->cleanup_startingflag at the beginning ofafr_notify()to skip notifications for volumes that are undergoing finalization (fini). This preventsafr_has_quorumfrom accessing already freedthis->private.Fix: #4644