Fix dead assignemnt in glfs_h_create_from_handle (clang-check)#4654
Open
ThalesBarretto wants to merge 1 commit intogluster:develfrom
Open
Fix dead assignemnt in glfs_h_create_from_handle (clang-check)#4654ThalesBarretto wants to merge 1 commit intogluster:develfrom
ThalesBarretto wants to merge 1 commit intogluster:develfrom
Conversation
A dead asssignment flagged by clang in glfs_h_create_from_handle occurs under the label 'found' when GF_CALLOC fails, when 'ret = -1' but in that path we end up bailing out and never using that value. Since we do not even return this value, the fix is just remove this dead line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead asssignment flagged by clang in glfs_h_create_from_handle
occurs under the label 'found' when GF_CALLOC fails, when 'ret = -1' but
in that path we end up bailing out and never using that value. Since we
do not even return this value, the fix is just remove this dead line.