Fix dead assignment in glfs_h_resolve_symlink (clang-check)#4656
Open
ThalesBarretto wants to merge 1 commit intogluster:develfrom
Open
Fix dead assignment in glfs_h_resolve_symlink (clang-check)#4656ThalesBarretto wants to merge 1 commit intogluster:develfrom
ThalesBarretto wants to merge 1 commit intogluster:develfrom
Conversation
When `glfs_active_subvol(fs)` fails, we set `ret = -1` but then go to out: without ever using the assigned value again. The fix removes this dead line because the exit path which follows does not use it. Signed-off-by: Thales Antunes de Oliveira Barretto <thales.barretto.git@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
glfs_active_subvol(fs)fails, we setret = -1but thengo to out: without ever using the assigned value again. The fix removes
this dead line because the exit path which follows does not use it.
Signed-off-by: Thales Antunes de Oliveira Barretto thales.barretto.git@gmail.com