libglusterfs: fix memory leak in gf_set_volfile_server_common#4661
Open
YifanZhang-311 wants to merge 1 commit intogluster:develfrom
Open
libglusterfs: fix memory leak in gf_set_volfile_server_common#4661YifanZhang-311 wants to merge 1 commit intogluster:develfrom
YifanZhang-311 wants to merge 1 commit intogluster:develfrom
Conversation
Problem: When gf_set_volfile_server_common() is called with a duplicate volfile server configuration, the function detects the duplicate and returns success (ret = 0). However, the newly allocated memory for server struct (server->volfile_server, server->transport, and server itself) is not freed before returning, causing a memory leak. Solution: Add GF_FREE() calls to release the allocated memory before returning on duplicate detection path.
Author
|
Hi @pranithk , could you please review this PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When gf_set_volfile_server_common() is called with a duplicate volfile server configuration, the function detects the duplicate and returns success (ret = 0). However, the newly allocated memory for server struct (server->volfile_server, server->transport, and server itself) is not freed before returning, causing a memory leak.
Solution:
Add GF_FREE() calls to release the allocated memory before returning on duplicate detection path.