Add FP4 since blackwell supports#11
Closed
winston-zhang-orz wants to merge 14 commits intogmasse:mainfrom
Closed
Conversation
Contributor
Author
|
hi @gmasse, Can you help review the PR ? |
Update fp4 in specs.json for all asics
gmasse
reviewed
Feb 27, 2025
data/specs.json
Outdated
| "cuda_compute_capability": { "full_name": "CUDA Compute Capability" }, | ||
| "power_consumption": { "full_name": "Power Consumption", "unit": "W" } | ||
| "power_consumption": { "full_name": "Power Consumption", "unit": "W" }, | ||
| "area": { "full_name": "Area", "unit": "mm2" } |
Owner
There was a problem hiding this comment.
To comply with NVIDIA data sheets, I suggest to name this field "Die Size" (die_size).
gmasse
reviewed
Feb 27, 2025
data/specs.json
Outdated
| "int4_tensor_core_sparsity": { "full_name": "INT4 Tensor Core with Sparsity", "unit": "TOPS" }, | ||
| "manufacturer": { "full_name": "Manufacturer" }, | ||
| "architecture": { "full_name": "Architecture" }, | ||
| "technology": { "full_name": "Technology" }, |
Owner
There was a problem hiding this comment.
To comply with NVIDIA data sheets, I suggest to name this field "Manufacturing Process" (process).
Owner
|
Thanks for your contribution @winston-zhang-orz . Please review my comments above. |
Owner
|
Hi @winston-zhang-orz |
Merged
Owner
|
Replaced by PR #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FP4 to header spec since blackwell supports fp4,
https://images.nvidia.com/aem-dam/Solutions/geforce/blackwell/nvidia-rtx-blackwell-gpu-architecture.pdf