[WIP] Use df.to_json(orient='table')
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Mar 4, 2017
jupyterlab_table/utils.py
Outdated
| return data.to_dict(orient='records') | ||
| if isinstance(data, pd.DataFrame): | ||
| data = sanitize_dataframe(data) | ||
| data = data.to_json(orient='table') |
rgbkrk
reviewed
Mar 4, 2017
jupyterlab_table/utils.py
Outdated
| data = sanitize_dataframe(data) | ||
| return data.to_dict(orient='records') | ||
| if isinstance(data, pd.DataFrame): | ||
| data = sanitize_dataframe(data) |
There was a problem hiding this comment.
Should the sanitization code end up in pandas?
There was a problem hiding this comment.
This sanitize_dataframe code comes from the original jupyterlab_vega which used to_dict(orient='records'). I think that to_json should take care of our sanitization needs?
rgbkrk
approved these changes
Mar 4, 2017
gnestor
changed the title
df.to_json(orient='table')df.to_json(orient='table')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on pandas 0.20.0: pandas-dev/pandas#14904