Skip to content

Conversation

@ulidtko
Copy link

@ulidtko ulidtko commented Feb 25, 2021

Hi!

First of all, thanks for publishing this tool. No matter how small, it is still useful, at least to me. I don't usually do PHP and, frankly, shy away from it. But this package is well-done, has crisp clear instructions, the code & packaging is understandable to an outsider (I've never run composer before) — and it worked right away, after very minor tinkering.

BTW, I used PHP 8.0.2 from my distro repositories. At first, it failed in the deprecated dependency dflydev/markdown like so:

Generating for invoice "2013-01-15-sample"...
PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/ulidtko/src/markdown-invoice/vendor/dflydev/markdown/src/dflydev/markdown/MarkdownExtraParser.php on line 347

Composer did a very nice suggestion:

Package dflydev/markdown is abandoned, you should avoid using it. Use michelf/php-markdown instead.

I did exactly that. Didn't touch the Symfony dependencies.

So there you have it: sincere words of appreciation from a "php hater" 😱 plus a patch. Take care & best wishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant