fix(gnodev): rewrite lazy loading proxy as HTTP reverse proxy#5276
Open
fix(gnodev): rewrite lazy loading proxy as HTTP reverse proxy#5276
Conversation
The TCP proxy maintained a persistent connection to the node's RPC server. When a PathHandler triggered a node reload (stop + restart), that connection died, causing the query that triggered the reload to silently fail. Replace the TCP-level proxy with an HTTP reverse proxy (httputil.ReverseProxy) so each request gets a fresh connection. The handler runs synchronously before forwarding, so after a reload the request naturally connects to the new node. Disable keep-alive on the transport to prevent stale pooled connections after restarts. Add TestProxyRestart to validate queries succeed across node restarts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core dev workflow of edit → query → see results
Test plan