Skip to content

chore(tm2): remove resolved TODO comments in state/store.go #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davd-gzl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(tm2): remove resolved TODO comments in state/store.go #5290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e26476f
chore(tm2): remove resolved TODO comments in state/store.go
davd-gzl Mar 14, 2026
154471f
Merge branch 'master' into fix/remove-resolved-todo-buf-read
davd-gzl Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tm2/pkg/bft/state/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ func loadState(db dbm.DB, key []byte) (state State) {
osm.Exit(fmt.Sprintf(`LoadState: Data has been corrupted or its spec has changed:
%v\n`, err))
}
// TODO: ensure that buf is completely read.

return state
}
Expand Down Expand Up @@ -178,7 +177,6 @@ func LoadABCIResponses(db dbm.DB, height int64) (*ABCIResponses, error) {
osm.Exit(fmt.Sprintf(`LoadABCIResponses: Data has been corrupted or its spec has
changed: %v\n`, err))
}
// TODO: ensure that buf is completely read.

return abciResponses, nil
}
Expand Down Expand Up @@ -294,7 +292,6 @@ func loadValidatorsInfo(db dbm.DB, height int64) *ValidatorsInfo {
osm.Exit(fmt.Sprintf(`LoadValidators: Data has been corrupted or its spec has changed:
%v\n`, err))
}
// TODO: ensure that buf is completely read.

return v
}
Expand Down Expand Up @@ -374,7 +371,6 @@ func loadConsensusParamsInfo(db dbm.DB, height int64) *ConsensusParamsInfo {
osm.Exit(fmt.Sprintf(`LoadConsensusParams: Data has been corrupted or its spec has changed:
%v\n`, err))
}
// TODO: ensure that buf is completely read.

return paramsInfo
}
Expand Down
Loading