Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmarking from evo.researcher #13

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Move benchmarking from evo.researcher #13

merged 9 commits into from
Feb 15, 2024

Conversation

evangriffiths
Copy link
Contributor

@evangriffiths evangriffiths commented Feb 14, 2024

Summary by CodeRabbit

  • New Features
    • Introduced benchmarking tools for prediction market agents, including:
      • Abstract and concrete classes for benchmarked agents with evaluation, research, and prediction methods.
      • A Benchmarker class for benchmarking agents, computing metrics, and generating comparison reports.
      • Utility functions for managing predictions, interacting with market APIs, and handling exceptional cases.
  • Tests
    • Added comprehensive test coverage for benchmarking prediction market agents, validating predictions, benchmark runs, and cache functionality.

Copy link

coderabbitai bot commented Feb 14, 2024

Warning

Rate Limit Exceeded

@evangriffiths has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 35 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 8ceda37 and 97c46bf.

Walkthrough

The update introduces a suite of tools for benchmarking prediction market agents, including classes for creating agents with random or fixed predictions, a benchmarker class for running comparisons, and utilities for managing predictions and interfacing with market APIs. It also includes tests to ensure the reliability and consistency of the benchmarking process and agent predictions.

Changes

File(s) Change Summary
.../benchmark/agents.py Introduces AbstractBenchmarkedAgent for agent evaluation, research, and prediction, along with RandomAgent and FixedAgent for generating respective types of predictions.
.../benchmark/benchmark.py Adds the Benchmarker class for benchmarking agents against prediction markets, including functionality for adding predictions, running agents, computing metrics, and report generation.
.../benchmark/utils.py Provides utilities for managing predictions and markets, including data models, functions for retrieving market data from APIs, calculating costs, and handling exceptions.
tests/test_benchmark.py Introduces tests for validating agent predictions, benchmark runs, caching predictions, and ensuring consistency in cached results, ensuring the reliability of the benchmarking process and the accuracy of the agents' prediction outcomes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 13

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ca12429 and e083331.
Files ignored due to path filters (2)
  • poetry.lock is excluded by: !**/*.lock
  • pyproject.toml is excluded by: !**/*.toml
Files selected for processing (4)
  • prediction_market_agent_tooling/benchmark/agents.py (1 hunks)
  • prediction_market_agent_tooling/benchmark/benchmark.py (1 hunks)
  • prediction_market_agent_tooling/benchmark/utils.py (1 hunks)
  • tests/test_benchmark.py (1 hunks)

prediction_market_agent_tooling/benchmark/agents.py Outdated Show resolved Hide resolved
prediction_market_agent_tooling/benchmark/agents.py Outdated Show resolved Hide resolved
prediction_market_agent_tooling/benchmark/agents.py Outdated Show resolved Hide resolved
prediction_market_agent_tooling/benchmark/agents.py Outdated Show resolved Hide resolved
tests/test_benchmark.py Outdated Show resolved Hide resolved
tests/test_benchmark.py Outdated Show resolved Hide resolved
tests/test_benchmark.py Outdated Show resolved Hide resolved
tests/test_benchmark.py Outdated Show resolved Hide resolved
prediction_market_agent_tooling/benchmark/utils.py Outdated Show resolved Hide resolved
@kongzii
Copy link
Contributor

kongzii commented Feb 15, 2024

Seems like just moving the files around? LGTM, feel free to just change to python 3.10 in mypy.ini

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e083331 and 8ceda37.
Files ignored due to path filters (2)
  • poetry.lock is excluded by: !**/*.lock
  • pyproject.toml is excluded by: !**/*.toml
Files selected for processing (4)
  • prediction_market_agent_tooling/benchmark/agents.py (1 hunks)
  • prediction_market_agent_tooling/benchmark/benchmark.py (1 hunks)
  • prediction_market_agent_tooling/benchmark/utils.py (1 hunks)
  • tests/test_benchmark.py (1 hunks)
Files skipped from review as they are similar to previous changes (4)
  • prediction_market_agent_tooling/benchmark/agents.py
  • prediction_market_agent_tooling/benchmark/benchmark.py
  • prediction_market_agent_tooling/benchmark/utils.py
  • tests/test_benchmark.py

@evangriffiths evangriffiths merged commit 2741963 into main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants