-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting of env vars in gcloud deploy #9
Conversation
WalkthroughThe recent update focuses on enhancing the deployment process for the prediction market agent tooling on Google Cloud Platform. Specifically, the modification involves a more secure and efficient handling of API keys during deployment by setting each key as an individual environment variable rather than concatenating them into a single string. This change aims to improve both the security and clarity of the deployment command. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for k, v in api_keys.items(): | ||
cmd += f"--set-env-vars {k}={v} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loop correctly iterates over api_keys
to set environment variables individually. However, this approach may lead to a command length limit issue if there are many API keys. Consider batching the environment variables or checking for command length limits.
Summary by CodeRabbit