OKX integration #97
Merged
OKX integration #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
reviewed
Jan 8, 2025
MartinquaXD
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OKX dex integration.
See also dedicated issue: #93
Changes
Added new
okxmodules index,configandtests.Created dto basing on documentation: https://www.okx.com/en-au/web3/build/docs/waas/dex-swap.
OKX requires signing of swap request, it is implemented in function:
sign_request(), basing on documentation: https://www.okx.com/en-au/web3/build/docs/waas/rest-authentication#signatureAlso implemented custom error handling function:
handle_api_error(), as OKX in error cases returns valid json http body which causes that trait implementation fromRoundtripErrortodto::Erroris not used.How to test
Created dedicated tests which uses http mocking and real endpoint tests (ignored) which requires providing API credentials. If API credentials are needed for running ignored test I can provide that.