Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sass by default, implement gulp to autoprefix, minify css and ugl… #28

Merged
merged 2 commits into from
May 20, 2017

Conversation

bilelmoussaoui
Copy link
Collaborator

@bilelmoussaoui bilelmoussaoui commented May 16, 2017

  • Use SASS instead of native CSS code (cleaner, easier to modify later)
  • Few fixes and cleannig
  • Use Gulp to autoprefix the css, minify the css & image, uglify js files, and few other stuff!
  • Fix W3C HTML validations issues
  • Add Feed.xml file (for RSS subscription)
  • Use Travis to compile test if sass & js files have no issues

Shouldn't be merged yet! Not all the stuff are implemented

…ify js, reduce img sizes and few design modifications
@bilelmoussaoui bilelmoussaoui merged commit 4170d55 into master May 20, 2017
@bilelmoussaoui bilelmoussaoui deleted the beta branch May 20, 2017 19:41
@bilelmoussaoui
Copy link
Collaborator Author

@gnunn1 I've merged this PR, this contains mostly some design improvements & code cleaning. It's now easier to modify the website in the future. Here's a small video that shows the before/after PR
https://youtu.be/X8Ups7E15Jo
There's just some few contents missing here https://gnunn1.github.io/tilix-web/manual/
I didn't know what to write...

@gnunn1
Copy link
Owner

gnunn1 commented May 21, 2017

Thanks, it looks great. I've gone ahead and updated the various manual titles to display appropriate text. Thanks for all your hard work on this, much appreciated!

@bilelmoussaoui
Copy link
Collaborator Author

it's the app i use every day for almost everything so :)
By the way, which application you've used to get this screenshot ? https://gnunn1.github.io/tilix-web/manual/quake/ I would like to update the others; in order to fix #21

@gnunn1
Copy link
Owner

gnunn1 commented May 21, 2017

I just use the gnome screenshot tool and press <alt><print screen>, nothing too complicated.

@gnunn1
Copy link
Owner

gnunn1 commented May 21, 2017

BTW I noticed in your video that you are underlining the title of the active terminal. I'm not sure if that's some custom CSS you are doing or something in the theme. However in case it is of interest, note that I've added support for the CSS active style for the .terminal-titlebar class so you can actually underline the whole titlebar if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants