ovh: allow to use ovh.conf file

[ldez]

Fixes #2215

[rbeuque74]

Hello,

Thanks for the patch. I suggested another way around here: ldez#2

What do you think ?

Romain

[dmke]

I'm a little confused: Where does it read the ovh.conf, and why was ovh/go-ovh#84 closed without merging?

[ldez]

The read of the file is inside the constructors of the client.

https://github.com/ovh/go-ovh/blob/9c5297024e0b551f222c66504a3ffdf7b0cd479b/ovh/configuration.go#L77-L91

https://github.com/ovh/go-ovh/blob/9c5297024e0b551f222c66504a3ffdf7b0cd479b/ovh/ovh.go#L103-L159

My PR was to be able to fill all the fields and then call loadConfig but by playing with constructors we can do the same.

It's not my preferred solution but it works as expected.

[dmke]

It's not my preferred solution but it works as expected.

I concur. It works now as expected, but as soon as OVH changes their client implementation (as likely or unlikely this may be) and the behaviour diverges, we have a problem.

I much prefer ovh/go-ovh#84 (or something similar) to become available, but alas, this seems to be the next best thing...