Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Rainyun/雨云 #2354

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Cikaros
Copy link

@Cikaros Cikaros commented Nov 18, 2024

The individual has been tested and is available normally~

@ldez
Copy link
Member

ldez commented Nov 18, 2024

Hello, in order for a PR adding a DNS provider to be accepted, you have to:

  • add a description to your PR
  • be able to maintain this provider
  • have a homogeneous design with the other providers
  • add tests (units)
make test
  • add tests ("live")
    func TestLivePresent(t *testing.T) {
    if !envTest.IsLiveTest() {
    t.Skip("skipping live test")
    }
    envTest.RestoreEnv()
    provider, err := NewDNSProvider()
    require.NoError(t, err)
    err = provider.Present(envTest.GetDomain(), "", "123d==")
    require.NoError(t, err)
    }
    func TestLiveCleanUp(t *testing.T) {
    if !envTest.IsLiveTest() {
    t.Skip("skipping live test")
    }
    envTest.RestoreEnv()
    provider, err := NewDNSProvider()
    require.NoError(t, err)
    time.Sleep(2 * time.Second)
    err = provider.CleanUp(envTest.GetDomain(), "", "123d==")
    require.NoError(t, err)
    }
make test
make generate-dns
  • be able to do: (and put the output of this command to a comment in your PR)
rm -rf .lego

RAINYUN_API_KEY="xxxxxxxxxxxxxxxxxxxxx" \
./dist/lego -m your@email.com --dns rainyun -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

make checks
  • do go mod tidy

@ldez ldez self-requested a review November 18, 2024 11:27
@ldez ldez changed the title Support Rain Cloud DNS Provider Add DNS provider for Rainyun/雨云 Nov 18, 2024
@ldez ldez force-pushed the feature/rain-cloud branch 3 times, most recently from 3c992d0 to 89ad42c Compare November 18, 2024 13:04
@Cikaros
Copy link
Author

Cikaros commented Nov 18, 2024

// TODO(ldez) based on the API style, this structure is probably wrong.
There's no problem with the JSON field here, because I've tried calling the API and the property is determined to be a big hump and not a small hump.
image

@Cikaros
Copy link
Author

Cikaros commented Nov 18, 2024

I'm sorry for the irregularity of what I wrote, I rarely write go

@ldez
Copy link
Member

ldez commented Nov 18, 2024

Please stop merging, instead rebase your local branch.

@ldez
Copy link
Member

ldez commented Nov 18, 2024

To fix your local branch quickly:

git switch master
git branch -D feature/rain-cloud
git switch feature/rain-cloud

@ldez
Copy link
Member

ldez commented Nov 18, 2024

Please stop with that: don't merge and don't push your merge.

@Cikaros
Copy link
Author

Cikaros commented Nov 18, 2024

Okay , I`m so sorry

@ldez
Copy link
Member

ldez commented Nov 18, 2024

I'm waiting for:

  • be able to do: (and put the output of this command to a comment in your PR)
rm -rf .lego

RAINYUN_API_KEY="xxxxxxxxxxxxxxxxxxxxx" \
./dist/lego -m your@email.com --dns rainyun -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

You should replace example.com with your domain.
You should replace your@email.com with your email.

The 2 domains with the same LTD are a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants