-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier TLS setup #120
Easier TLS setup #120
Conversation
I made this a draft until I get a better idea on how the integration with a TLS library would look like. I're looked at autocert but I found it lacking some features. Right now I think both library would work by hooking into the |
What you've implemented here is fine for the scope of the issue and you shouldn't worry about the other integration in this Pull Request as I'm sure the next PR will have a lot more discussion 😉 |
I've added the custom TLSConfig option and removed the I would like to also contribute on example of TLS server setup to show people how this can be leveraged better but I still have some bits to figure out here. |
Added |
* certmagic poc * add missing flag parse * add with tls config from acme client * listen on http too * manage sync + https redir * updated acme tls example * acme tls update with comments * remove debug log from acme-tls example * acme-tls RunTLS
Also pushed my working example for TLS with ACME Server (Let's Encrypt Staging) using certmagic. Let me know if think it's useful otherwise I can remove it. |
Nice, do you mind submitting a separate PR for the example. It's easier on the repo history and makes things easier to find. |
@dylanhitt removed the example, will open a new PR with that after we are done with this one, since it requires the code. |
Work to address the easier TLS setup discussed here: #113.
The goals would be to:
support custom TLS configuration to have easy option to hook TLS library (for ACME protocol TLS managers that can handle everything automatically)not required not, since you can access Fuego's underlinghttp.Server
to set thetls.Config
directly.