Ci/markdown lint #138
Merged
Ci/markdown lint #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
approved these changes
Jul 3, 2024
ccoVeille
reviewed
Jul 6, 2024
| code_blocks: false | ||
| tables: false | ||
|
|
||
| MD033: false |
There was a problem hiding this comment.
These disabled rules might sound opinionated, mainly because they come without a comment about what they are about and why they are deactivated.
I know markdown lint, and I'm OK with the rules you chose, but I think comments would help
There was a problem hiding this comment.
Good point, we definitely should add a summary about what they are disabling for each one at the very least.
Feel free to do it if you like, if not I’ll slide into my day Monday
Cheers
There was a problem hiding this comment.
I could, but I'm not in your head and the reason why you removed might differ from what I think you removed them 😅
There was a problem hiding this comment.
Awesome thanks, I’ll add you to review Monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
Let me know if anyone has opinions on the rules.
Thanks