-
-
Notifications
You must be signed in to change notification settings - Fork 111
feat: add ErrorWithDetail #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1b10ce
to
85461e3
Compare
@EwenQuim should I update the docs? |
8ec3821
to
8b4c4df
Compare
a70e700
to
41ab130
Compare
I’ll update the docs as well tomorrow. |
27fbf60
to
b39acd7
Compare
@EwenQuim if you don't mind looking at the doc updates that would be great. I'm not the best writer. |
If you're not the best writer, then I'm a terrible one. The doc update is great! |
0b8bd39
to
3ab8b64
Compare
@EwenQuim you mind taking another look. Trying to clear my backlog |
Nice, thanks! Yes don't worry, Fuego is very active at the moment. But that's a good sign! We'll be taking a break during winter holidays. |
Closes #225
Adds
ErrorWithDetail
interface to allow for response of detail. This is similar to the older with Info. The motivation for this is the fact that we use the detail option in theslog.Error
in the default error handler as well as in theHTTPError.Error()
func. Maybe we should default into something as well in the case where the user doesn't supply it.If this is acceptable I will update the docs now as well.