Fix/validate cookies

ctx.go

@@ -205,6 +205,11 @@ func (c ContextNoBody) Header(key string) string {
 	return c.Request().Header.Get(key)
 }
 
+// Has request header
+func (c ContextNoBody) HasHeader(key string) bool {
+	return c.Header(key) != ""
+}
+
 // Sets response header
 func (c ContextNoBody) SetHeader(key, value string) {
 	c.Response().Header().Set(key, value)
@@ -215,6 +220,12 @@ func (c ContextNoBody) Cookie(name string) (*http.Cookie, error) {
 	return c.Request().Cookie(name)
 }
 
+// Has request cookie
+func (c ContextNoBody) HasCookie(name string) bool {
+	_, err := c.Cookie(name)
+	return err == nil
+}
+
 // Sets response cookie
 func (c ContextNoBody) SetCookie(cookie http.Cookie) {
 	http.SetCookie(c.Response(), &cookie)

ctx_params_test.go

@@ -38,20 +38,4 @@ func TestParam(t *testing.T) {
 			require.Equal(t, "hey18true", w.Body.String())
 		})
 	})
-
-	t.Run("Should enforce Required", func(t *testing.T) {
-		s := fuego.NewServer()
-
-		fuego.Get(s, "/test", func(c fuego.ContextNoBody) (string, error) {
-			name := c.QueryParam("name")
-			return name, nil
-		},
-			option.Query("name", "Name", param.Required(), param.Example("example1", "you")),
-		)
-		r := httptest.NewRequest("GET", "/test", nil)
-		w := httptest.NewRecorder()
-		s.Mux.ServeHTTP(w, r)
-		require.Equal(t, http.StatusBadRequest, w.Code)
-		require.Contains(t, w.Body.String(), "name is a required query param")
-	})
 }

documentation/docs/tutorials/02-crud.md

@@ -86,7 +86,7 @@ func main() {
 	s := fuego.NewServer()
 	// ....
 
-	// Declare the ressource
+	// Declare the resource
 	booksResources := controllers.BooksResources{
 		BooksService: controllers.RealBooksService{},
 		// Other services & dependencies, like a DB etc.

serve.go

@@ -54,33 +54,13 @@ func (s *Server) proto() string {
 	return "http"
 }
 
-func validateQueryParams(c ContextNoBody) error {
-	for k, param := range c.params {
-		if param.Default != nil {
-			// skip: param has a default
-			continue
-		}
-
-		if param.Required && !c.urlValues.Has(k) {
-			err := fmt.Errorf("%s is a required query param", k)
-			return BadRequestError{
-				Title:  "Query Param Not Found",
-				Err:    err,
-				Detail: "cannot parse request parameter: " + err.Error(),
-			}
-		}
-	}
-
-	return nil
-}
-
 // initializes any Context type with the base ContextNoBody context.
 //
 //	var ctx ContextWithBody[any] // does not work because it will create a ContextWithBody[any] with a nil value
 func initContext[Contextable ctx[Body], Body any](baseContext ContextNoBody) (Contextable, error) {
 	var c Contextable
 
-	err := validateQueryParams(baseContext)
+	err := validateParams(baseContext)
 	if err != nil {
 		return c, err
 	}

validateParams.go

@@ -0,0 +1,46 @@
+package fuego
+
+import "fmt"
+
+func validateParams(c ContextNoBody) error {
+	for k, param := range c.params {
+		if param.Default != nil {
+			// skip: param has a default
+			continue
+		}
+
+		if param.Required {
+			switch param.Type {
+			case QueryParamType:
+				if !c.urlValues.Has(k) {
+					err := fmt.Errorf("%s is a required query param", k)
+					return BadRequestError{
+						Title:  "Query Param Not Found",
+						Err:    err,
+						Detail: "cannot parse request parameter: " + err.Error(),
+					}
+				}
+			case HeaderParamType:
+				if !c.HasHeader(k) {
+					err := fmt.Errorf("%s is a required header", k)
+					return BadRequestError{
+						Title:  "Header Not Found",
+						Err:    err,
+						Detail: "cannot parse request parameter: " + err.Error(),
+					}
+				}
+			case CookieParamType:
+				if !c.HasCookie(k) {
+					err := fmt.Errorf("%s is a required cookie", k)
+					return BadRequestError{
+						Title:  "Cookie Not Found",
+						Err:    err,
+						Detail: "cannot parse request parameter: " + err.Error(),
+					}
+				}
+			}
+		}
+	}
+
+	return nil
+}

validateParams_test.go

@@ -0,0 +1,54 @@
+package fuego_test
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/go-fuego/fuego"
+	"github.com/go-fuego/fuego/option"
+	"github.com/go-fuego/fuego/param"
+)
+
+func TestParamsValidation(t *testing.T) {
+	t.Run("Should enforce Required query parameter", func(t *testing.T) {
+		s := fuego.NewServer()
+
+		fuego.Get(s, "/test", dummyController,
+			option.Query("name", "Name", param.Required(), param.Example("example1", "you")),
+		)
+		r := httptest.NewRequest("GET", "/test", nil)
+		w := httptest.NewRecorder()
+		s.Mux.ServeHTTP(w, r)
+		require.Equal(t, http.StatusBadRequest, w.Code)
+		require.Contains(t, w.Body.String(), "name is a required query param")
+	})
+
+	t.Run("Should enforce Required header", func(t *testing.T) {
+		s := fuego.NewServer()
+
+		fuego.Get(s, "/test", dummyController,
+			option.Header("foo", "header that is foo", param.Required()),
+		)
+		r := httptest.NewRequest("GET", "/test", nil)
+		w := httptest.NewRecorder()
+		s.Mux.ServeHTTP(w, r)
+		require.Equal(t, http.StatusBadRequest, w.Code)
+		require.Contains(t, w.Body.String(), "foo is a required header")
+	})
+
+	t.Run("Should enforce Required cookie", func(t *testing.T) {
+		s := fuego.NewServer()
+
+		fuego.Get(s, "/test", dummyController,
+			option.Cookie("bar", "cookie that is bar", param.Required()),
+		)
+		r := httptest.NewRequest("GET", "/test", nil)
+		w := httptest.NewRecorder()
+		s.Mux.ServeHTTP(w, r)
+		require.Equal(t, http.StatusBadRequest, w.Code)
+		require.Contains(t, w.Body.String(), "bar is a required cookie")
+	})
+}