Cli/add service generation #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thank you very much for this PR, it'll greatly help new Fuego users try the framework !
Next step, a proposal for using SQL 😉 I'm joking, this can be a real challenge and there are so many different ways of implementing SQL...
A few minor changes need to be addressed in order to ensure the maintainability of this feature, even if there is no doubt that you made it work nicely.
|
Btw fixes #256 |
dylanhitt
reviewed
Dec 10, 2024
rizerkrof
force-pushed
the
cli/add-service-generation
branch
from
90839c4 to
1548948
Compare
rizerkrof
force-pushed
the
cli/add-service-generation
branch
from
1548948 to
5d13e87
Compare
dylanhitt
approved these changes
Dec 17, 2024
dylanhitt
reviewed
Dec 17, 2024
EwenQuim
approved these changes
Dec 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added on the
fuego controllercli command a flag (--with-service) to generate a simple in memory map based service that satisfies the controller service interface.The generated service can be pass into the controller resources to have a fully functional CRUD.