Gin compat #260
Merged
Gin compat #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
force-pushed
the
gin-compat
branch
4 times, most recently
from
b4d06b5 to
778d992
Compare
EwenQuim
force-pushed
the
gin-compat
branch
11 times, most recently
from
542238f to
0b9a903
Compare
ccoVeille
reviewed
Dec 14, 2024
|
It's a draft, but I have feedbacks
|
|
Thanks for the memes @ccoVeille 😆 |
EwenQuim
force-pushed
the
gin-compat
branch
4 times, most recently
from
a27812f to
99dbbd2
Compare
|
Please notify when this is ready. looks good so far! |
EwenQuim
force-pushed
the
gin-compat
branch
6 times, most recently
from
1cfcd77 to
7f4fd23
Compare
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
I keep Context[...] for later usage, to not break backward compatibility, becase it currently does not look like its definitive form.
ccoVeille
approved these changes
Dec 22, 2024
dylanhitt
approved these changes
Dec 23, 2024
genslein
added a commit
to genslein/fuego
that referenced
this pull request
Dec 30, 2024
EwenQuim
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step towards #241 : it works!!! 🎉
🚧 Ultra-WIP as it is not ready for production.
Enables the way for Echo & other frameworks.
The (challengeable) goal here is not to support both frameworks but to allow smooth transition towards stdlib.
EDIT:
I want to merge this quickly as a first step towards supporting Gin. On the nice side, it's not a fuego release, it is an
extraso it won't impact the main releases (and it will be a long running feature si that's nice).