- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
Fix review request webhook bug #35339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            lunny
  merged 5 commits into
  go-gitea:release/v1.24
from
lunny:lunny/fix_review_request_webhook
  
      
      
   
  Aug 29, 2025 
      
    
                
     Merged
            
            Fix review request webhook bug #35339
                    lunny
  merged 5 commits into
  go-gitea:release/v1.24
from
lunny:lunny/fix_review_request_webhook
  
      
      
   
  Aug 29, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Ci fail seems related | 
| 
 8988396 should fix the problem. | 
              
                    lafriks
  
              
              approved these changes
              
                  
                    Aug 25, 2025 
                  
              
              
            
            
              
                    techknowlogick
  
              
              approved these changes
              
                  
                    Aug 28, 2025 
                  
              
              
            
            
    
  lunny 
      added a commit
        to lunny/gitea
      that referenced
      this pull request
    
      Oct 6, 2025 
    
    
      
  
    
      
    
  
partially backport go-gitea#35337 Fix go-gitea#35327
    
  lunny 
      added a commit
        to lunny/gitea
      that referenced
      this pull request
    
      Oct 22, 2025 
    
    
      
  
    
      
    
  
partially backport go-gitea#35337 Fix go-gitea#35327
    
  lunny 
      added a commit
      that referenced
      this pull request
    
      Oct 24, 2025 
    
    
  
    
  lunny 
      added a commit
      that referenced
      this pull request
    
      Oct 24, 2025 
    
    
  
    
  zjjhot 
      added a commit
        to zjjhot/gitea
      that referenced
      this pull request
    
      Oct 30, 2025 
    
    
      
  
    
      
    
  
* giteaofficial/main: [skip ci] Updated translations via Crowdin Revert go-gitea#18491, fix oauth2 client link account (go-gitea#35745) Upgrade go mail to 0.7.2 (go-gitea#35748) [skip ci] Updated translations via Crowdin Support actions and reusable workflows from private repos (go-gitea#32562) Use git model to detect whether branch exist instead of gitrepo method (go-gitea#35459) Fix shutdown waitgroup panic (go-gitea#35676) Intorduce "config edit-ini" sub command to help maintaining INI config file (go-gitea#35735) Improve online runner check (go-gitea#35722) Make "update file" API can create a new file when SHA is not set (go-gitea#35738) Fix review request webhook bug (go-gitea#35339) (go-gitea#35723) Misc tool tweaks (go-gitea#35734) Update dependencies (go-gitea#35733) Make external iframe render work (go-gitea#35730) Remove mermaid margin workaround (go-gitea#35732) # Conflicts: # models/user/user.go
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    lgtm/done
  This PR has enough approvals to get merged. There are no important open reservations anymore. 
  
    modifies/go
  Pull requests that update Go code 
  
    type/bug
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
partially backport #35337
Fix #35327