Skip to content

feat: add substring and substr for field String

Sign in for the full log view
GitHub Actions / golangci failed Aug 20, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (2)

field/string.go|150 col 1| exported: exported method String.Substring should have comment or be unexported (revive)
field/string.go|166 col 1| exported: exported method String.Substr should have comment or be unexported (revive)

Filtered Findings (47)

field/expr.go|126 col 23| Error return value of builder.WriteString is not checked (errcheck)
field/serializer.go|22 col 13| Error return value of db.AddError is not checked (errcheck)
do.go|263 col 18| Error return value of stmt.WriteByte is not checked (errcheck)
do.go|294 col 18| Error return value of stmt.WriteByte is not checked (errcheck)
internal/template/method.go|1 col 1| package-comments: should have a package comment (revive)
internal/utils/common.go|1 col 1| package-comments: should have a package comment (revive)
field/time.go|113 col 1| exported: exported method Time.Year should have comment or be unexported (revive)
field/association.go|240 col 1| exported: exported method RelateConfig.GetTag should have comment or be unexported (revive)
field/assign_attr.go|13 col 6| exported: exported type IValues should have comment or be unexported (revive)
field/assign_attr.go|115 col 1| exported: exported function Attrs should have comment or be unexported (revive)
field/export.go|325 col 118| unused-parameter: parameter 'relations' seems to be unused, consider removing or renaming it as _ (revive)
field/tag.go|9 col 2| exported: exported const TagKeyGorm should have comment (or a comment on this block) or be unexported (revive)
field/tag.go|12 col 2| exported: comment on exported const TagKeyGormColumn should be of the form "TagKeyGormColumn ..." (revive)
field/tag.go|41 col 6| exported: exported type TagBuilder should have comment or be unexported (revive)
field/tag.go|45 col 6| exported: exported type Tag should have comment or be unexported (revive)
field/tag.go|47 col 1| exported: exported method Tag.Set should have comment or be unexported (revive)
field/tag.go|52 col 1| exported: exported method Tag.Remove should have comment or be unexported (revive)
field/tag.go|57 col 1| exported: exported method Tag.Build should have comment or be unexported (revive)
field/tag.go|73 col 6| exported: exported type GormTag should have comment or be unexported (revive)
field/tag.go|75 col 1| exported: exported method GormTag.Append should have comment or be unexported (revive)
field/tag.go|84 col 1| exported: exported method GormTag.Set should have comment or be unexported (revive)
field/tag.go|89 col 1| exported: exported method GormTag.Remove should have comment or be unexported (revive)
field/tag.go|94 col 1| exported: exported method GormTag.Build should have comment or be unexported (revive)
field/tag.go|10 col 2| var-naming: const TagKeyJson should be TagKeyJSON (revive)
field/serializer.go|12 col 6| exported: exported type ValuerType should have comment or be unexported (revive)
field/serializer.go|18 col 1| exported: exported method ValuerType.GormValue should have comment or be unexported (revive)
field/serializer.go|26 col 1| exported: comment on exported type Serializer should be of the form "Serializer ..." (with optional leading article) (revive)
field/expr.go|56 col 6| exported: exported type IColumnName should have comment or be unexported (revive)
field/serializer.go|21 col 33| context-keys-type: should not use basic type string as key in context.WithValue (revive)
internal/parser/export.go|1 col 1| package-comments: should have a package comment (revive)
internal/parser/method.go|12 col 1| exported: exported function DefaultMethodTableName should have comment or be unexported (revive)
internal/generate/query.go|17 col 6| exported: exported type FieldParser should have comment or be unexported (revive)
internal/generate/table.go|74 col 37| unused-parameter: parameter 'schemaName' seems to be unused, consider removing or renaming it as _ (revive)
internal/generate/table.go|86 col 35| unused-parameter: parameter 'schemaName' seems to be unused, consider removing or renaming it as _ (revive)
do_options.go|21 col 36| unused-parameter: parameter 'db' seems to be unused, consider removing or renaming it as _ (revive)
do_options.go|9 col 6| exported: exported type DOConfig should have comment or be unexported (revive)
field_options.go|23 col 2| exported: exported var FieldModify should have comment or be unexported (revive)
field_options.go|266 col 2| exported: exported var DefaultMethodTableWithNamer should have comment or be unexported (revive)
do.go|851 col 1| exported: exported method DO.AddError should have comment or be unexported (revive)
internal/generate/section.go|563 col 108| (*Section).checkSQLVar - result err is always nil (unparam)
internal/model/options.go|10 col 5| var defaultSchemaNameOpt is unused (unused)
internal/generate/interface.go|446 col 27| func (*InterfaceMethod).checkSQLVarByParams is unused (unused)
internal/generate/interface.go|487 col 27| func (*InterfaceMethod).isParamExist is unused (unused)
internal/generate/section.go|694 col 2| field suffix is unused (unused)
field_options.go|20 col 5| var ns is unused (unused)
generator.go|302 col 4| shadow: declaration of "err" shadows declaration at line 286 (govet)
generator.go|489 col 4| shadow: declaration of "err" shadows declaration at line 469 (govet)

Annotations

Check failure on line 150 in field/string.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] field/string.go#L150

exported: exported method String.Substring should have comment or be unexported (revive)
Raw output
field/string.go:150:1: exported: exported method String.Substring should have comment or be unexported (revive)
func (field String) Substring(params ...int) String {
^

Check failure on line 166 in field/string.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] field/string.go#L166

exported: exported method String.Substr should have comment or be unexported (revive)
Raw output
field/string.go:166:1: exported: exported method String.Substr should have comment or be unexported (revive)
func (field String) Substr(params ...int) String {
^