Update mysql.go #132
Closed
Update mysql.go #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove ON DUPLICATE KEY UPDATE statement by onConflict.DoNothing is true
3 tasks
jinzhu
reviewed
Oct 10, 2023
| @@ -200,6 +200,10 @@ func (dialector Dialector) ClauseBuilders() map[string]clause.ClauseBuilder { | |||
| c.Build(builder) | |||
| return | |||
| } | |||
| // onConflict DoNothing, remove ON DUPLICATE KEY UPDATE statement | |||
There was a problem hiding this comment.
it will returns an error after remove the on duplicate update?
There was a problem hiding this comment.
db.Session(&gorm.Session{FullSaveAssociations: true}).Clauses(clause.OnConflict{DoNothing: true}).Create(m)
当我明确指定 clause.OnConflict{DoNothing: true}
那么该报错报错, 而不是自动修正.
如果没有明确声明clause.OnConflict{DoNothing: true}, 那么自动添加on duplicate 语句是一种合理的方式.
There was a problem hiding this comment.
When users specified DoNothing as true, we would expect users don't received any error when there are any duplicated record.
There was a problem hiding this comment.
那你是希望在什么情况下报错呢? 在关于外键并没有任何可以报错的选项
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed go-gorm/gorm#6566
remove ON DUPLICATE KEY UPDATE statement by onConflict.DoNothing is true