Skip to content

Add support for time.Time objects to gorp. #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coopernurse merged 2 commits into from
Sep 15, 2013
Merged

Add support for time.Time objects to gorp. #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa59f8
Add support for time.Time objects to gorp.
seehuhn Aug 10, 2013
e5a6512
For PostgreSQL use "timestamp with timezone" as suggested by Joe Shaw
seehuhn Sep 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dialect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ func (d SqliteDialect) ToSqlType(val reflect.Type, maxsize int, isAutoIncr bool)
return "integer"
case "NullableBytes":
return "blob"
case "Time":
return "datetime"
}

if maxsize < 1 {
Expand Down Expand Up @@ -170,6 +172,8 @@ func (d PostgresDialect) ToSqlType(val reflect.Type, maxsize int, isAutoIncr boo
return "smallint"
case "NullableBytes":
return "bytea"
case "Time", "NullTime":
return "timestamp with time zone"
}

if maxsize < 1 {
Expand Down Expand Up @@ -264,6 +268,8 @@ func (m MySQLDialect) ToSqlType(val reflect.Type, maxsize int, isAutoIncr bool)
return "tinyint"
case "NullableBytes":
return "mediumblob"
case "Time":
return "datetime"
}

if maxsize < 1 {
Expand Down
25 changes: 25 additions & 0 deletions gorp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,30 @@ func TestWithStringPk(t *testing.T) {
}
}

type WithTime struct {
Id int64
Time time.Time
}

func TestWithTime(t *testing.T) {
dbmap := initDbMap()
defer dbmap.DropTables()

t1, err := time.Parse("2006-01-02 15:04:05 -0700 MST",
"2013-08-09 21:30:43 +0800 CST")
if err != nil {
panic(err)
}
w1 := WithTime{1, t1}
_insert(dbmap, &w1)

obj := _get(dbmap, WithTime{}, w1.Id)
w2 := obj.(*WithTime)
if w1.Time.UnixNano() != w2.Time.UnixNano() {
t.Errorf("%v != %v", w1, w2)
}
}

func TestInvoicePersonView(t *testing.T) {
dbmap := initDbMap()
defer dbmap.DropTables()
Expand Down Expand Up @@ -1017,6 +1041,7 @@ func initDbMap() *DbMap {
dbmap.AddTableWithName(WithIgnoredColumn{}, "ignored_column_test").SetKeys(true, "Id")
dbmap.AddTableWithName(TypeConversionExample{}, "type_conv_test").SetKeys(true, "Id")
dbmap.AddTableWithName(WithEmbeddedStruct{}, "embedded_struct_test").SetKeys(true, "Id")
dbmap.AddTableWithName(WithTime{}, "time_test").SetKeys(true, "Id")
dbmap.TypeConverter = testTypeConverter{}
err := dbmap.CreateTables()
if err != nil {
Expand Down