Align required_without with the contract stated in the documentation#1422
Merged
nodivbyzero merged 1 commit intogo-playground:masterfrom Apr 28, 2025
Merged
Conversation
nodivbyzero
approved these changes
Apr 24, 2025
Contributor
nodivbyzero
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Everything looks good to me.
Contributor
Author
Are there any other steps I need to take to help this fix be applied? If so, just let me know :) @nodivbyzero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Resolves #617
Fixes
required_withoutso that it aligns with the stated contract and usage examples.The docs valid usage to be:
However, as show in this issue: #617, you can only use
required_withouton multiple fields like:This PR aligns the behavior of the
required_withoutvalidator such that you can also use it as shown in the example:Make sure that you've checked the boxes below before you submit PR:
Note: Sorry for the duplication of #1324. I was cleaning up my profile and deleted my fork before it could be merged.
@go-playground/validator-maintainers