fix: add thumbnail URL in print command #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #838 Add `imageURL` field to `shiori print -j` command and `api/v1/bookmarks/` endpoint * **BookmarksDomain**: Add `populateImageURL` method to set `ImageURL` field. Update `GetBookmark` method to call `populateImageURL` method. * **BookmarksDomain Tests**: Add test for `populateImageURL` method in `TestBookmarkDomain` function. * **API**: Update `getBookmark` method in `internal/http/routes/api/v1/bookmarks.go` to include `ImageURL` field in response. * **API Tests**: Add test for `ImageURL` field in `TestReadableeBookmarkContent` function. * **CLI**: Update `printHandler` function in `internal/cmd/print.go` to get the bookmarks using the `BookmarksDomain` present in `deps` instead of `deps.Database`. Remove the loop that calls `populateImageUrl`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/go-shiori/shiori/issues/838?shareId=XXXX-XXXX-XXXX-XXXX).
* Add `TestImageURLField` subtest to verify `ImageURL` field is populated correctly * Add two test cases: one for when `ImageURL` is populated and one for when it is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
Add
imageURLfield toshiori print -jcommand andapi/v1/bookmarks/endpointpopulateImageURLmethod to setImageURLfield. UpdateGetBookmarkmethod to callpopulateImageURLmethod.populateImageURLmethod inTestBookmarkDomainfunction.getBookmarkmethod ininternal/http/routes/api/v1/bookmarks.goto includeImageURLfield in response.ImageURLfield inTestReadableeBookmarkContentfunction.printHandlerfunction ininternal/cmd/print.goto get the bookmarks using theBookmarksDomainpresent indepsinstead ofdeps.Database. Remove the loop that callspopulateImageUrl.For more details, open the Copilot Workspace session.