Skip to content

docs: improve kubernetes deployment docs #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hackeryarn
Copy link
Contributor

This tries to improve the docs enough to sufficiently cover the ask of #1039.

This is the configuration that I am currently running, and it it stripped down to the simplest deployment that works with all the features.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.06%. Comparing base (378e633) to head (4095166).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files          70       70           
  Lines        5929     5929           
=======================================
  Hits         2435     2435           
  Misses       3214     3214           
  Partials      280      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -85,10 +85,6 @@ spec:
labels:
app: shiori
spec:
securityContext:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not running mine in k8s anymore, but last time I did this was necessary, did we fix it along the way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question on how it got fixed. I tried it in k3s and kind, just to try a more restrictive environment, and it ran without the security context in both.

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! I love how you explained every step to make it work :)

@fmartingr fmartingr merged commit cac1ba8 into go-shiori:master Mar 8, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants