Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issues with the v0.6.0-rc.1 #68

Merged
merged 15 commits into from
Sep 16, 2024
Merged

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented Sep 15, 2024

Description

This pull requests grabs returns for the v0.6.0-rc.1 (Release Candidate 1) and resolve issues related to it.

Changes

  • Add Raw prefix to Functions and Aliases function to be more comprehensible and prevent confusion with Funcs() from sprig.
  • Remove deprecated NewFunctionhandler labelled as deprecated in v0.2.0 to prepare the v1.0.0
  • Ensure a built function map cannot be rebuild and cause memory growing
  • Prevent to creating an alias on a no-existant function name

Fixes #66, #67

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys self-assigned this Sep 15, 2024
@42atomys 42atomys linked an issue Sep 15, 2024 that may be closed by this pull request
1 task
@go-sprout go-sprout deleted a comment from codecov bot Sep 15, 2024
@42atomys 42atomys marked this pull request as ready for review September 15, 2024 14:17
@42atomys 42atomys requested review from a team and ccoVeille and removed request for a team September 15, 2024 14:17
@go-sprout go-sprout deleted a comment from codecov bot Sep 15, 2024
@42atomys 42atomys enabled auto-merge (squash) September 15, 2024 14:31
@42atomys 42atomys requested a review from ccoVeille September 15, 2024 20:33
@42atomys 42atomys force-pushed the fix/returns-of-0.6.0-rc1 branch from c854630 to 648a8c5 Compare September 16, 2024 14:57
@42atomys 42atomys requested a review from ccoVeille September 16, 2024 14:57
@42atomys 42atomys merged commit c5fccb4 into main Sep 16, 2024
15 checks passed
@42atomys 42atomys deleted the fix/returns-of-0.6.0-rc1 branch September 16, 2024 16:05
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
alias.go 80.0% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
handler.go 100.0% <100.0%> (ø)
notice.go 100.0% <100.0%> (ø)
registry.go 100.0% <100.0%> (ø)
sprigin/sprig_backward_compatibility.go 100.0% <100.0%> (ø)
sprout.go 100.0% <100.0%> (ø)
alias.go 90.9% <80.0%> (-9.1%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: add WithRegistries and WithRegistry opts bug: multiple build occur growing wrapped function
2 participants