Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api/story): change ID type from Multi[int] to Multi[int64] #64

Merged
merged 10 commits into from
Mar 15, 2025

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Mar 15, 2025

fixed #60

Summary by CodeRabbit

  • Refactor
    • Enhanced the handling of unique identifiers to support a broader range of numeric values. This update improves the system's capability when processing larger ID numbers.
  • Bug Fixes
    • Updated the status of the functionality to retrieve requirements from the recycle bin, indicating it is no longer implemented.

…]` in `GetStoriesRequest`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 15, 2025
Copy link

coderabbitai bot commented Mar 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifying the data types of various fields across multiple request structs in the api_story.go file from *Multi[int] to *Multi[int64] and from *int to *int64. This transition allows for the handling of 64-bit integers for IDs, which may accommodate a larger range of values. Additionally, the api_story_test.go file updates type specifications in test cases to ensure consistency with these changes. The features.md file reflects a change in the implementation status of a specific feature.

Changes

File Change Summary
api_story.go Updated multiple request structs to change field types from *Multi[int] to *Multi[int64] and from *int to *int64.
api_story_test.go Updated test cases to specify int64 in NewMulti and Ptr function calls for consistency.
features.md Changed status of "获取回收站下的需求" from checked ([x]) to unchecked ([ ]).

Possibly related PRs

Poem

I’m a coding rabbit, hopping in the night,
Seeing 64-bit numbers twinkle so bright.
My code now leaps with a wider view,
Celebrating the change, both fresh and new.
With each little jump, I cheer in delight! 🐇

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf4a5b1 and 7ae3611.

📒 Files selected for processing (3)
  • api_story.go (11 hunks)
  • api_story_test.go (7 hunks)
  • features.md (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
api_story.go 44.49% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125 flc1125 marked this pull request as draft March 15, 2025 12:08
@dosubot dosubot bot added the go Pull requests that update Go code label Mar 15, 2025
flc1125 added 9 commits March 15, 2025 20:16
…]` in `GetStoriesCountRequest`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoriesCountRequest`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoryCategories`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoryCategoriesCount`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoriesCountByCategories`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetConvertStoryIDsToQueryToken`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoryRelatedBugs`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…]` in `GetStoryTemplateFields`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
…toryRequest` and `CategoryID`

Signed-off-by: Flc <four_leaf_clover@foxmail.com>
@flc1125 flc1125 marked this pull request as ready for review March 15, 2025 13:02
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 15, 2025
@flc1125 flc1125 merged commit c8f78dd into master Mar 15, 2025
12 of 13 checks passed
@dosubot dosubot bot added the enhancement New feature or request label Mar 15, 2025
@flc1125 flc1125 deleted the fix-story-id branch March 15, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: change story ID type from int to int64
1 participant