Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI_ARGS completion for fish and zsh (#1843) #1844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boiledfroginthewell
Copy link

fixes: #1843

Comment on lines +66 to 67
'(operation)*: :__task_list' \
+ '(operation)' \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task-name completions didn't work except for the first positional argument in zsh, but this has been fixed as well.

(Argument specifications after + '(operation)' become mutually exclusive options. In the previous code, *: :__task_list also prevented other task names from being suggested when one task name is specified in a command line.)

Comment on lines -62 to +72
'(-*)'{-h,--help}'[show help]' \
'(-*)--version[show version and exit]' \
'*: :__task_list'
'(*)'{-l,--list}'[list describable tasks]' \
'(*)'{-a,--list-all}'[list all tasks]' \
'(*)'{-i,--init}'[create new Taskfile.yml]' \
'(- *)'{-h,--help}'[show help]' \
'(- *)--version[show version and exit]' \
Copy link
Author

@boiledfroginthewell boiledfroginthewell Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- (-*)--version
+ (- *)--version

I suppose (- *) is the intended one. This prevents all options and positional arguments from being suggested when the --version option is supplied.

(The parentheses specify groups of arguments to prevent suggestions. - and * are special group names for options and rest positional arguments, respectively. I think the -* group is not defined here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fish/zsh shell completions suggest task names even for CLI_ARGS
1 participant