Watch: restarts tasks only when at least one watched file changes. #2493
+41
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task(s) is watched, and a watched event occurs, then; the current context is cancelled (which signals the task and sub-tasks), then the watch conditions are evaluated, and finally if the watch conditions are satsified, then the task(s) are restarted.
This means that if a watch condition is not satisified (i.e. "skipped for file not in sources") then the task is cancelled and not restarted.
In this PR the logic is altered as follows: First the watch condition is evaluated, if at least one task(s) satisifies the condition then all tasks are cancelled, and then all tasks restarted. When no task satisified the watch contition, no action is taken. Given the way this code behaves, I believe its an improvement within the scope of the known limitations of the method used (i.e. the Context object).
closes #2477