-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pipeline): set max template depth and adjust CompileLite call #467
Conversation
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 86.49% 86.41% -0.09%
==========================================
Files 145 145
Lines 6288 6300 +12
==========================================
+ Hits 5439 5444 +5
- Misses 694 700 +6
- Partials 155 156 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider allowing override of template depth only when validating local templates to avoid potential of flooding SCM with template requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves issue where
vela validate pipeline --template --template-file < ... >
results in an error due to the template depth not being set in the CLI's compiler instance. Error also exists withvela exec pipeline
.