Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user resource management #574

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Sep 6, 2024

While it may not get a ton of use, I think it's nice to have support for user resource management (adding favorites, adding dashboards, etc.)

I can see this getting enhanced in the future, specifically on the admin side of things with maybe blocking users or revoking tokens or something.

@ecrupper ecrupper requested a review from a team as a code owner September 6, 2024 14:54
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 84.68468% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@32b3fc2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
action/user/update.go 82.00% 5 Missing and 4 partials ⚠️
command/pipeline/exec.go 0.00% 3 Missing ⚠️
command/user/update.go 87.50% 1 Missing and 1 partial ⚠️
command/user/view.go 83.33% 1 Missing and 1 partial ⚠️
action/pipeline/exec.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage        ?   75.54%           
=======================================
  Files           ?      172           
  Lines           ?     4462           
  Branches        ?        0           
=======================================
  Hits            ?     3371           
  Misses          ?      855           
  Partials        ?      236           
Files with missing lines Coverage Δ
action/pipeline/validate.go 80.62% <100.00%> (ø)
action/user/user.go 100.00% <100.00%> (ø)
action/user/view.go 100.00% <100.00%> (ø)
command/pipeline/validate.go 71.42% <100.00%> (ø)
action/pipeline/exec.go 0.00% <0.00%> (ø)
command/user/update.go 87.50% <87.50%> (ø)
command/user/view.go 83.33% <83.33%> (ø)
command/pipeline/exec.go 0.00% <0.00%> (ø)
action/user/update.go 82.00% <82.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit fcf8c86 into main Sep 6, 2024
15 of 18 checks passed
@ecrupper ecrupper deleted the feat/user-resource-management branch September 6, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants