Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove types dependency #583

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 22, 2024 14:44
timhuynh94
timhuynh94 previously approved these changes Oct 22, 2024
KellyMerrick
KellyMerrick previously approved these changes Oct 22, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper dismissed stale reviews from KellyMerrick and timhuynh94 via 2a0da43 October 22, 2024 14:46
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (e8b493d) to head (2a0da43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
action/secret/add.go 50.00% 1 Missing ⚠️
action/secret/update.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   75.52%   79.38%   +3.86%     
==========================================
  Files         172      172              
  Lines        4461     7728    +3267     
==========================================
+ Hits         3369     6135    +2766     
- Misses        856     1357     +501     
  Partials      236      236              
Files with missing lines Coverage Δ
action/deployment/add.go 93.61% <100.00%> (+2.31%) ⬆️
action/deployment/table.go 100.00% <100.00%> (ø)
action/hook/table.go 100.00% <100.00%> (ø)
action/pipeline/exec.go 0.00% <ø> (ø)
action/pipeline/stage.go 100.00% <ø> (ø)
action/pipeline/step.go 100.00% <ø> (ø)
action/pipeline/table.go 100.00% <100.00%> (ø)
action/pipeline/validate.go 82.32% <ø> (+1.70%) ⬆️
action/repo/validate.go 100.00% <ø> (ø)
action/secret/get.go 94.64% <ø> (+2.05%) ⬆️
... and 20 more

... and 142 files with indirect coverage changes

@ecrupper ecrupper merged commit 55c73d4 into main Oct 22, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/log-and-misc branch October 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants