Skip to content
reviewdog

refactor(secret): use server API types for secret #6372

Sign in to view logs

refactor(secret): use server API types for secret

refactor(secret): use server API types for secret #6372

Triggered via pull request October 17, 2024 17:15
@ecrupperecrupper
opened #1209
refactor/nested-api/secret
Status Failure
Total duration 3m 2s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 44s
diff-review
full-review
2m 52s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
diff-review: mock/server/authentication.go#L84
string `error` has 4 occurrences, make it a constant (goconst)
diff-review: compiler/types/pipeline/ruleset.go#L134
cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
diff-review: database/types/build.go#L384
G115: integer overflow conversion int -> int32 (gosec)
diff-review: database/types/build.go#L385
G115: integer overflow conversion int -> int32 (gosec)
diff-review: database/types/repo.go#L336
G115: integer overflow conversion int -> int32 (gosec)
diff-review: database/types/settings.go#L134
G115: integer overflow conversion int64 -> uint64 (gosec)
diff-review: database/types/settings.go#L205
G115: integer overflow conversion uint64 -> int64 (gosec)
diff-review: secret/vault/create.go#L18
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: secret/vault/delete.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: secret/vault/get.go#L18
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/server/authentication.go#L84
string `error` has 4 occurrences, make it a constant (goconst)
full-review: compiler/types/pipeline/ruleset.go#L134
cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
full-review: database/types/build.go#L384
G115: integer overflow conversion int -> int32 (gosec)
full-review: database/types/build.go#L385
G115: integer overflow conversion int -> int32 (gosec)
full-review: database/types/repo.go#L336
G115: integer overflow conversion int -> int32 (gosec)
full-review: database/types/settings.go#L134
G115: integer overflow conversion int64 -> uint64 (gosec)
full-review: database/types/settings.go#L205
G115: integer overflow conversion uint64 -> int64 (gosec)
full-review: secret/vault/delete.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: secret/vault/refresh_test.go#L45
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
full-review: secret/vault/refresh_test.go#L71
unused-parameter: parameter 'in' seems to be unused, consider removing or renaming it as _ (revive)