refactor(pipeline): use server API types for pipeline and migrate com…

…piler types (#1200)

* refactor(pipeline): use server API types for pipeline and migrate compiler types

* gci

api/build/auto_cancel.go

@@ -15,10 +15,10 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal/token"
 	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/pipeline"
 )
 
 // AutoCancel is a helper function that checks to see if any pending or running

api/build/auto_cancel_test.go

@@ -6,8 +6,8 @@ import (
 	"testing"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/pipeline"
 )
 
 func Test_isCancelable(t *testing.T) {

api/build/compile_publish.go

@@ -15,14 +15,13 @@ import (
 
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/compiler"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/queue"
 	"github.com/go-vela/server/queue/models"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/pipeline"
 )
 
 // CompileAndPublishConfig is a struct that contains information for the CompileAndPublish function.
@@ -181,7 +180,7 @@ func CompileAndPublish(
 		// variable to store executable pipeline
 		p *pipeline.Build
 		// variable to store pipeline configuration
-		pipeline *library.Pipeline
+		pipeline *types.Pipeline
 		// variable to store the pipeline type for the repository
 		pipelineType = r.GetPipelineType()
 		// variable to store updated repository record
@@ -257,7 +256,7 @@ func CompileAndPublish(
 			repo.SetPipelineType(pipeline.GetType())
 		}
 
-		var compiled *library.Pipeline
+		var compiled *types.Pipeline
 		// parse and compile the pipeline configuration file
 		p, compiled, err = compiler.
 			Duplicate().
@@ -311,7 +310,7 @@ func CompileAndPublish(
 		// check if the pipeline did not already exist in the database
 		if pipeline == nil {
 			pipeline = compiled
-			pipeline.SetRepoID(repo.GetID())
+			pipeline.SetRepo(repo)
 			pipeline.SetCommit(b.GetCommit())
 			pipeline.SetRef(b.GetRef())
 

api/build/executable.go

@@ -12,12 +12,12 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
 	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/pipeline"
 )
 
 // swagger:operation GET /api/v1/repos/{org}/{repo}/builds/{build}/executable builds GetBuildExecutable

api/build/graph.go

@@ -12,6 +12,7 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/compiler"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/router/middleware/build"
@@ -21,7 +22,6 @@ import (
 	"github.com/go-vela/server/util"
 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/pipeline"
 )
 
 // Graph contains nodes, and relationships between nodes, or edges.

api/build/plan.go

@@ -12,9 +12,9 @@ import (
 	"github.com/go-vela/server/api/service"
 	"github.com/go-vela/server/api/step"
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/scm"
-	"github.com/go-vela/types/pipeline"
 )
 
 // PlanBuild is a helper function to plan the build for

api/build/skip.go

@@ -3,7 +3,7 @@
 package build
 
 import (
-	"github.com/go-vela/types/pipeline"
+	"github.com/go-vela/server/compiler/types/pipeline"
 )
 
 // SkipEmptyBuild checks if the build should be skipped due to it

api/build/skip_test.go

@@ -5,7 +5,7 @@ package build
 import (
 	"testing"
 
-	"github.com/go-vela/types/pipeline"
+	"github.com/go-vela/server/compiler/types/pipeline"
 )
 
 func Test_SkipEmptyBuild(t *testing.T) {

api/pipeline/compile.go

@@ -11,12 +11,12 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/compiler"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/internal"
 	pMiddleware "github.com/go-vela/server/router/middleware/pipeline"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/pipeline"
 )
 
 // swagger:operation POST /api/v1/pipelines/{org}/{repo}/{pipeline}/compile pipelines CompilePipeline

api/pipeline/compile_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/google/go-cmp/cmp"
 
-	"github.com/go-vela/types/pipeline"
+	"github.com/go-vela/server/compiler/types/pipeline"
 )
 
 // TestPrepareRuleData tests the prepareRuleData function.

api/pipeline/create.go

@@ -9,10 +9,10 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/library"
 )
 
 // swagger:operation POST /api/v1/pipelines/{org}/{repo} pipelines CreatePipeline
@@ -75,7 +75,7 @@ func CreatePipeline(c *gin.Context) {
 	l.Debugf("creating new pipeline for repo %s", r.GetFullName())
 
 	// capture body from API request
-	input := new(library.Pipeline)
+	input := new(types.Pipeline)
 
 	err := c.Bind(input)
 	if err != nil {
@@ -87,7 +87,7 @@ func CreatePipeline(c *gin.Context) {
 	}
 
 	// update fields in pipeline object
-	input.SetRepoID(r.GetID())
+	input.SetRepo(r)
 
 	// send API call to create the pipeline
 	p, err := database.FromContext(c).CreatePipeline(ctx, input)

api/pipeline/template.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/go-vela/server/compiler"
 	"github.com/go-vela/server/compiler/registry/github"
+	"github.com/go-vela/server/compiler/types/yaml"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/router/middleware/org"
 	"github.com/go-vela/server/router/middleware/pipeline"
@@ -20,7 +21,6 @@ import (
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
 	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/yaml"
 )
 
 // swagger:operation GET /api/v1/pipelines/{org}/{repo}/{pipeline}/templates pipelines GetTemplates

api/pipeline/update.go

@@ -9,11 +9,11 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/pipeline"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/library"
 )
 
 // swagger:operation PUT /api/v1/pipelines/{org}/{repo}/{pipeline} pipelines UpdatePipeline
@@ -83,7 +83,7 @@ func UpdatePipeline(c *gin.Context) {
 	l.Debugf("updating pipeline %s", entry)
 
 	// capture body from API request
-	input := new(library.Pipeline)
+	input := new(types.Pipeline)
 
 	err := c.Bind(input)
 	if err != nil {

api/service/plan.go

@@ -10,10 +10,10 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/pipeline"
 )
 
 // PlanServices is a helper function to plan all services

api/step/plan.go

@@ -10,11 +10,11 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/compiler/types/pipeline"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
-	"github.com/go-vela/types/pipeline"
 )
 
 // PlanSteps is a helper function to plan all steps

api/types/build.go

@@ -7,8 +7,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/go-vela/server/compiler/types/raw"
 	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/raw"
 )
 
 // Build is the API types representation of a build for a pipeline.

api/types/build_test.go

@@ -10,7 +10,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 
-	"github.com/go-vela/types/raw"
+	"github.com/go-vela/server/compiler/types/raw"
 )
 
 func TestTypes_Build_Duration(t *testing.T) {

api/types/deployment.go

@@ -5,7 +5,7 @@ package types
 import (
 	"fmt"
 
-	"github.com/go-vela/types/raw"
+	"github.com/go-vela/server/compiler/types/raw"
 )
 
 // Deployment is the API representation of a deployment.

api/types/executor.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/go-vela/types/pipeline"
+	"github.com/go-vela/server/compiler/types/pipeline"
 )
 
 // Executor is the API representation of an executor for a worker.

api/types/executor_test.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/go-vela/types/pipeline"
+	"github.com/go-vela/server/compiler/types/pipeline"
 )
 
 func TestTypes_Executor_Getters(t *testing.T) {