chore: cleanup and linting

api/build/plan.go

@@ -57,7 +57,7 @@ func PlanBuild(ctx context.Context, database database.Interface, scm scm.Service
 	}
 
 	// plan all steps for the build
-	steps, err := step.PlanSteps(ctx, database, scm, p, b, r)
+	steps, err := step.PlanSteps(ctx, database, scm, p, b)
 	if err != nil {
 		// clean up the objects from the pipeline in the database
 		CleanBuild(ctx, database, b, services, steps, err)

api/step/plan.go

@@ -19,7 +19,7 @@ import (
 // PlanSteps is a helper function to plan all steps
 // in the build for execution. This creates the steps
 // for the build.
-func PlanSteps(ctx context.Context, database database.Interface, scm scm.Service, p *pipeline.Build, b *types.Build, r *types.Repo) ([]*types.Step, error) {
+func PlanSteps(ctx context.Context, database database.Interface, scm scm.Service, p *pipeline.Build, b *types.Build) ([]*types.Step, error) {
 	// variable to store planned steps
 	steps := []*types.Step{}
 

scm/github/app_client.go

@@ -19,7 +19,7 @@ import (
 )
 
 // NewGitHubAppTransport creates a new GitHub App transport for authenticating as the GitHub App.
-func NewGitHubAppTransport(appID int64, privateKey, baseUrl string) (*AppsTransport, error) {
+func NewGitHubAppTransport(appID int64, privateKey, baseURL string) (*AppsTransport, error) {
 	decodedPEM, err := base64.StdEncoding.DecodeString(privateKey)
 	if err != nil {
 		return nil, fmt.Errorf("error decoding base64: %w", err)
@@ -36,7 +36,7 @@ func NewGitHubAppTransport(appID int64, privateKey, baseUrl string) (*AppsTransp
 	}
 
 	transport := NewAppsTransportFromPrivateKey(http.DefaultTransport, appID, _privateKey)
-	transport.BaseURL = baseUrl
+	transport.BaseURL = baseURL
 
 	return transport, nil
 }

scm/github/app_transport.go

@@ -37,7 +37,8 @@ type AppsTransport struct {
 	Client  Client            // Client to use to refresh tokens, defaults to http.Client with provided transport
 	tr      http.RoundTripper // tr is the underlying roundtripper being wrapped
 	signer  Signer            // signer signs JWT tokens.
-	appID   int64             // appID is the GitHub App's ID
+	//nolint:unused // ignore false positive
+	appID int64 // appID is the GitHub App's ID
 }
 
 // NewAppsTransportFromPrivateKey returns an AppsTransport using a crypto/rsa.(*PrivateKey).
@@ -174,6 +175,7 @@ func (t *Transport) Expiry() (expiresAt time.Time, refreshAt time.Time, err erro
 	if t.token == nil {
 		return time.Time{}, time.Time{}, errors.New("Expiry() = unknown, err: nil token")
 	}
+
 	return t.token.ExpiresAt, t.token.getRefreshTime(), nil
 }
 
@@ -207,7 +209,7 @@ func (t *Transport) refreshToken(ctx context.Context) error {
 
 	resp, err := t.appsTransport.RoundTrip(req)
 	if err != nil {
-		return fmt.Errorf("could not get access_tokens from GitHub API for installation ID %v: %v", t.installationID, err)
+		return fmt.Errorf("could not get access_tokens from GitHub API for installation ID %v: %w", t.installationID, err)
 	}
 
 	if resp.StatusCode/100 != 2 {