refactor(steps/services): use server API types for steps and services (…

…#1210) * refactor(steps/services): use server API types for steps and services * gci
go-vela · Oct 18, 2024 · c701bd8 · c701bd8
1 parent 37f2c35
commit c701bd8
Show file tree

Hide file tree

Showing 384 changed files with 4,153 additions and 611 deletions.
diff --git a/api/admin/clean.go b/api/admin/clean.go
@@ -11,10 +11,10 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/util"
 	"github.com/go-vela/types"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation PUT /api/v1/admin/clean admin AdminCleanResources

diff --git a/api/admin/service.go b/api/admin/service.go
@@ -10,9 +10,9 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/library"
 )
 
 // swagger:operation PUT /api/v1/admin/service admin AdminUpdateService
@@ -59,7 +59,7 @@ func UpdateService(c *gin.Context) {
 	l.Debug("platform admin: updating service")
 
 	// capture body from API request
-	input := new(library.Service)
+	input := new(types.Service)
 
 	err := c.Bind(input)
 	if err != nil {

diff --git a/api/admin/step.go b/api/admin/step.go
@@ -10,9 +10,9 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/library"
 )
 
 // swagger:operation PUT /api/v1/admin/step admin AdminUpdateStep
@@ -58,7 +58,7 @@ func UpdateStep(c *gin.Context) {
 	l.Debug("platform admin: updating step")
 
 	// capture body from API request
-	input := new(library.Step)
+	input := new(types.Step)
 
 	err := c.Bind(input)
 	if err != nil {

diff --git a/api/admin/worker.go b/api/admin/worker.go
@@ -9,9 +9,9 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/internal/token"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
 )
 

diff --git a/api/auth/logout.go b/api/auth/logout.go
@@ -10,11 +10,11 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation GET /logout authenticate GetLogout

diff --git a/api/auth/post_token.go b/api/auth/post_token.go
@@ -9,11 +9,11 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal/token"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
 )
 

diff --git a/api/badge.go b/api/badge.go
@@ -8,10 +8,10 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation GET /badge/{org}/{repo}/status.svg base GetBadge

diff --git a/api/build/approve.go b/api/build/approve.go
@@ -12,14 +12,14 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/queue"
 	"github.com/go-vela/server/queue/models"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation POST /api/v1/repos/{org}/{repo}/builds/{build}/approve builds ApproveBuild

diff --git a/api/build/auto_cancel.go b/api/build/auto_cancel.go
@@ -16,9 +16,9 @@ import (
 
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/compiler/types/pipeline"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal/token"
-	"github.com/go-vela/types/constants"
 )
 
 // AutoCancel is a helper function that checks to see if any pending or running

diff --git a/api/build/auto_cancel_test.go b/api/build/auto_cancel_test.go
@@ -7,7 +7,7 @@ import (
 
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/compiler/types/pipeline"
-	"github.com/go-vela/types/constants"
+	"github.com/go-vela/server/constants"
 )
 
 func Test_isCancelable(t *testing.T) {

diff --git a/api/build/cancel.go b/api/build/cancel.go
@@ -13,14 +13,14 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal/token"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/executors"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation DELETE /api/v1/repos/{org}/{repo}/builds/{build}/cancel builds CancelBuild

diff --git a/api/build/clean.go b/api/build/clean.go
@@ -10,15 +10,14 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
-	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/library"
 )
 
 // cleanBuild is a helper function to kill the build
 // without execution. This will kill all resources,
 // like steps and services, for the build.
-func CleanBuild(ctx context.Context, database database.Interface, b *types.Build, services []*library.Service, steps []*library.Step, e error) {
+func CleanBuild(ctx context.Context, database database.Interface, b *types.Build, services []*types.Service, steps []*types.Step, e error) {
 	l := logrus.WithFields(logrus.Fields{
 		"build":    b.GetNumber(),
 		"build_id": b.GetID(),

diff --git a/api/build/compile_publish.go b/api/build/compile_publish.go
@@ -16,12 +16,12 @@ import (
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/compiler"
 	"github.com/go-vela/server/compiler/types/pipeline"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/queue"
 	"github.com/go-vela/server/queue/models"
 	"github.com/go-vela/server/scm"
-	"github.com/go-vela/types/constants"
 )
 
 // CompileAndPublishConfig is a struct that contains information for the CompileAndPublish function.

diff --git a/api/build/graph.go b/api/build/graph.go
@@ -11,17 +11,17 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/compiler"
 	"github.com/go-vela/server/compiler/types/pipeline"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/library"
 )
 
 // Graph contains nodes, and relationships between nodes, or edges.
@@ -46,10 +46,10 @@ type node struct {
 	Name    string `json:"name"`
 
 	// vela metadata
-	Status     string          `json:"status"`
-	StartedAt  int             `json:"started_at"`
-	FinishedAt int             `json:"finished_at"`
-	Steps      []*library.Step `json:"steps"`
+	Status     string        `json:"status"`
+	StartedAt  int           `json:"started_at"`
+	FinishedAt int           `json:"finished_at"`
+	Steps      []*types.Step `json:"steps"`
 
 	// unexported data used for building edges
 	Stage *pipeline.Stage `json:"-"`
@@ -67,7 +67,7 @@ type edge struct {
 
 // stg represents a stage's steps and some metadata for producing node/edge information.
 type stg struct {
-	steps []*library.Step
+	steps []*types.Step
 	// used for tracking stage status
 	success    int
 	running    int
@@ -241,7 +241,7 @@ func GetBuildGraph(c *gin.Context) {
 	}
 
 	// retrieve the steps for the build from the step table
-	steps := []*library.Step{}
+	steps := []*types.Step{}
 	page := 1
 	perPage := 100
 
@@ -279,7 +279,7 @@ func GetBuildGraph(c *gin.Context) {
 	}
 
 	// retrieve the services for the build from the service table
-	services := []*library.Service{}
+	services := []*types.Service{}
 	page = 1
 	perPage = 100
 
@@ -359,7 +359,7 @@ func GetBuildGraph(c *gin.Context) {
 		// initialize a stage tracker
 		if _, ok := stageMap[name]; !ok {
 			stageMap[name] = &stg{
-				steps: []*library.Step{},
+				steps: []*types.Step{},
 			}
 		}
 
@@ -615,13 +615,13 @@ func nodeFromStage(nodeID, cluster int, stage *pipeline.Stage, s *stg) *node {
 }
 
 // nodeFromService returns a new node from a service.
-func nodeFromService(nodeID int, service *library.Service) *node {
+func nodeFromService(nodeID int, service *types.Service) *node {
 	return &node{
 		ID:         nodeID,
 		Cluster:    ServiceCluster,
 		Name:       service.GetName(),
 		Stage:      nil,
-		Steps:      []*library.Step{},
+		Steps:      []*types.Step{},
 		Status:     service.GetStatus(),
 		StartedAt:  int(service.GetStarted()),
 		FinishedAt: int(service.GetFinished()),

diff --git a/api/build/list_org.go b/api/build/list_org.go
@@ -12,12 +12,12 @@ import (
 
 	"github.com/go-vela/server/api"
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/org"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation GET /api/v1/repos/{org}/builds builds ListBuildsForOrg

diff --git a/api/build/list_repo.go b/api/build/list_repo.go
@@ -13,10 +13,10 @@ import (
 
 	"github.com/go-vela/server/api"
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation GET /api/v1/repos/{org}/{repo}/builds builds ListBuildsForRepo

diff --git a/api/build/restart.go b/api/build/restart.go
@@ -12,6 +12,7 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/compiler"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/internal"
 	"github.com/go-vela/server/queue"
@@ -21,7 +22,6 @@ import (
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation POST /api/v1/repos/{org}/{repo}/builds/{build} builds RestartBuild

diff --git a/api/build/token.go b/api/build/token.go
@@ -11,12 +11,12 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/internal/token"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/claims"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 	"github.com/go-vela/types/library"
 )
 

diff --git a/api/build/update.go b/api/build/update.go
@@ -10,13 +10,12 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api/types"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/build"
 	"github.com/go-vela/server/router/middleware/repo"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
-	"github.com/go-vela/types/library"
 )
 
 // swagger:operation PUT /api/v1/repos/{org}/{repo}/builds/{build} builds UpdateBuild
@@ -191,7 +190,7 @@ func UpdateComponentStatuses(c *gin.Context, b *types.Build, status string) erro
 	l.Debug("updating component statuses")
 
 	// retrieve the steps for the build from the step table
-	steps := []*library.Step{}
+	steps := []*types.Step{}
 	page := 1
 	perPage := 100
 
@@ -230,7 +229,7 @@ func UpdateComponentStatuses(c *gin.Context, b *types.Build, status string) erro
 	}
 
 	// retrieve the services for the build from the service table
-	services := []*library.Service{}
+	services := []*types.Service{}
 	page = 1
 
 	for page > 0 {

diff --git a/api/metrics.go b/api/metrics.go
@@ -12,9 +12,9 @@ import (
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"github.com/sirupsen/logrus"
 
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/queue"
-	"github.com/go-vela/types/constants"
 )
 
 // MetricsQueryParameters holds query parameter information pertaining to requested metrics.

diff --git a/api/repo/create.go b/api/repo/create.go
@@ -14,12 +14,12 @@ import (
 
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/server/api/types/actions"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/settings"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation POST /api/v1/repos repos CreateRepo

diff --git a/api/repo/list_org.go b/api/repo/list_org.go
@@ -11,12 +11,12 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/go-vela/server/api"
+	"github.com/go-vela/server/constants"
 	"github.com/go-vela/server/database"
 	"github.com/go-vela/server/router/middleware/org"
 	"github.com/go-vela/server/router/middleware/user"
 	"github.com/go-vela/server/scm"
 	"github.com/go-vela/server/util"
-	"github.com/go-vela/types/constants"
 )
 
 // swagger:operation GET /api/v1/repos/{org} repos ListReposForOrg