-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hook): nest API response and use Gorm preload to populate repo and build data #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 52.41% 53.06% +0.65%
==========================================
Files 557 559 +2
Lines 19433 19722 +289
==========================================
+ Hits 10185 10466 +281
- Misses 8682 8688 +6
- Partials 566 568 +2
|
plyr4
previously approved these changes
Sep 11, 2024
wass3rw3rk
approved these changes
Sep 13, 2024
wass3rw3rk
added a commit
to go-vela/types
that referenced
this pull request
Sep 13, 2024
plyr4
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing efforts from: #1111
Hook.Repo
andHook.Build.Repo
are duplicative, so I prunedHook.Build.Repo
to only includeHook.Build.Repo.ID
.